Conversation
Closed
b135dc8 to
52363c2
Compare
for more information, see https://pre-commit.ci
52363c2 to
cdd1345
Compare
cdd1345 to
d396107
Compare
08eb143 to
f9d92f2
Compare
mitchh456
reviewed
Jan 8, 2025
add support for sample_endpoint/job_rate
mitchh456
reviewed
Jan 13, 2025
mitchh456
reviewed
Jan 14, 2025
mitchh456
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Samplerclass which handles:startswithto be consistent with how the currentignore_pathlogic works.Configmodule to accept new configuration options:sample_endpoint_rateandsample_job_ratewhich work as a endpoint/job catchall, with the fallback value still being the globalsample_rate.